Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

porting things to niquests #6023

Merged
merged 6 commits into from
Oct 8, 2024
Merged

porting things to niquests #6023

merged 6 commits into from
Oct 8, 2024

Conversation

shaneknapp
Copy link
Contributor

@shaneknapp shaneknapp commented Aug 26, 2024 •
edited
Loading

i'd like to start here before fixing all of the images that have requests installed....

i tested the python in scripts and things work exactly as intended. i also tested the scaler via the steps here, and again, everything is working as intended.

this resolves https://github.com/berkeley-dsep-infra/datahub/security/dependabot/182

ryanlovett
ryanlovett approved these changes Oct 8, 2024
View reviewed changes
Copy link
Collaborator

@ryanlovett ryanlovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense for how requests is used in these places. If niquests isn't as compatible as we think, we can replace with python's http.client, or aiohttp.

@shaneknapp
Copy link
Contributor Author

I think this makes sense for how requests is used in these places. If niquests isn't as compatible as we think, we can replace with python's http.client, or aiohttp.

tbf, it really does seem to be as compatible... :)

another thing i was thinking of doing was importing niquests directly, and then s/requests/niquests/g in all of the scripts... but since this work and was a much simpler change, i'm inclined to leave things as they are in this PR.

@ryanlovett
Copy link
Collaborator

another thing i was thinking of doing was importing niquests directly, and then s/requests/niquests/g in all of the scripts... but since this work and was a much simpler change, i'm inclined to leave things as they are in this PR.

Yeah, I thought the same thing. "niquists as requests" kind of documents why it is being used.

@shaneknapp shaneknapp merged commit f7abb04 into berkeley-dsep-infra:staging Oct 8, 2024
3 checks passed
@shaneknapp shaneknapp deleted the port-to-niquests branch October 8, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanlovett ryanlovett ryanlovett approved these changes

@felder felder Awaiting requested review from felder

Assignees
No one assigned
Labels
configuration helm-config hub-images jupyterhub-deployment node-placeholder-deployment node-placeholder-scaler python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaneknapp @ryanlovett